# Accounting Reports Menu Not Showing - Troubleshooting Guide

## Issue
The Accounting Reports module menu and child items are not showing in the admin sidebar menu list.

## Fixes Applied

### 1. Enhanced Module Installation Check
- Added fallback check using `ModuleUtil::isModuleInstalled()`
- Checks both `accountingreports_version` and `AccountingReports_version` system properties
- Added logging to track installation status

### 2. Improved Permission Checks
- Added admin and superadmin bypass for all menu items
- Menu now shows for:
  - Users with any accounting permission
  - Admin role users
  - Superadmin users

### 3. Better Error Handling
- Added comprehensive logging throughout the menu generation process
- Menu instance validation
- Fallback text for missing translations

### 4. Menu Item Counting
- Added counter to track how many menu items are added
- Logs the count for debugging

## Troubleshooting Steps

### Step 1: Check Module Installation
```sql
SELECT * FROM system WHERE `key` = 'accountingreports_version';
```

If no result, the module is not installed. Install it via:
- Go to Settings → Manage Modules
- Find "AccountingReports" module
- Click Install

Or manually set:
```sql
INSERT INTO system (`key`, `value`, `created_at`, `updated_at`) 
VALUES ('accountingreports_version', '1.0.3', NOW(), NOW());
```

### Step 2: Check User Permissions
The menu will show if the user has ANY of these:
- Admin role: `Admin#{business_id}`
- Superadmin permission
- Any accounting permission (accounting.view_all, accounting.view_trial_balance, etc.)

To grant permissions:
1. Go to Settings → Roles & Permissions
2. Edit the user's role
3. Check at least one accounting permission
4. Save

### Step 3: Check Logs
Check Laravel logs for menu-related errors:
```bash
tail -f storage/logs/laravel.log | grep AccountingReports
```

Look for:
- "AccountingReports: Module installed, checking permissions"
- "AccountingReports: User has permissions, adding menu items"
- "AccountingReports: Menu added successfully with X items"

### Step 4: Clear Cache
```bash
php artisan cache:clear
php artisan config:clear
php artisan route:clear
php artisan view:clear
```

### Step 5: Verify Module Registration
Check if the module is registered:
```bash
php artisan module:list
```

Should show "AccountingReports" in the list.

### Step 6: Check DataController Method
Verify the `modifyAdminMenu()` method exists:
```php
// File: Modules/AccountingReports/Http/Controllers/DataController.php
// Method: modifyAdminMenu()
```

### Step 7: Manual Menu Test
Add this to a controller to test:
```php
$menu = Menu::instance('admin-sidebar-menu');
$menu->url(route('accounting-reports.index'), 'Test Menu', ['icon' => 'fas fa-test']);
```

## Common Issues

### Issue 1: Module Not Installed
**Symptom**: Menu doesn't appear at all
**Solution**: Install the module via module manager or set system property

### Issue 2: No Permissions
**Symptom**: Menu doesn't appear
**Solution**: Grant at least one accounting permission to the user

### Issue 3: Menu Instance Not Found
**Symptom**: Error in logs about menu instance
**Solution**: Ensure AdminSidebarMenu middleware is loaded

### Issue 4: Translation Missing
**Symptom**: Menu shows but with errors
**Solution**: Added fallback text (e.g., 'Accounting Reports' if translation missing)

## Code Changes Made

1. **Enhanced Installation Check**:
   ```php
   $module_util = new \App\Utils\ModuleUtil();
   $is_installed = $module_util->isModuleInstalled('AccountingReports');
   ```

2. **Admin/Superadmin Bypass**:
   ```php
   $is_admin = auth()->user()->hasRole('Admin#' . session('business.id'));
   $is_superadmin = auth()->user()->can('superadmin');
   ```

3. **Permission Check Update**:
   ```php
   if (auth()->user()->can('accounting.view_all') || $is_admin || $is_superadmin) {
       // Show menu item
   }
   ```

4. **Logging Added**:
   - Module installation status
   - Permission checks
   - Menu item count
   - Errors with full trace

## Testing

After applying fixes:
1. Clear all caches
2. Log out and log back in
3. Check if menu appears
4. Check logs for any errors
5. Verify permissions are set correctly

## Still Not Working?

1. Check if other modules' menus are showing (to verify menu system works)
2. Check browser console for JavaScript errors
3. Verify the user has a valid session
4. Check if the module is enabled in business settings
5. Review Laravel logs for any exceptions